Skip to content

Conversation

@wert2all
Copy link
Contributor

@wert2all wert2all commented Dec 2, 2025

📑 Description

Laravel Pint is an opinionated PHP code style fixer for Laravel. This PR will install pint LSP and add formatter for php files.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From pint readme:

Pint is built on top of PHP-CS-Fixer and makes it simple to ensure that your code style stays clean and consistent.

Cant php-cs-fixer me removed?

@wert2all wert2all force-pushed the app-pint-to-laravel branch from a2b1cd9 to 4572a34 Compare December 2, 2025 08:52
@wert2all
Copy link
Contributor Author

wert2all commented Dec 2, 2025

Cant php-cs-fixer me removed?

removed and force pushed

@Uzaaft
Copy link
Member

Uzaaft commented Dec 4, 2025

@wert2all Have you tested this pack yet? I see it imports the php pack, which uses the php-cs-fixer. Just want to make sure nothing collides.

@wert2all
Copy link
Contributor Author

wert2all commented Dec 5, 2025

@wert2all Have you tested this pack yet? I see it imports the php pack, which uses the php-cs-fixer. Just want to make sure nothing collides.

Yes, I created a PR from my config.

20251205_12h52m44s_grim

which uses the php-cs-fixer.

pint is wrapper over php-cs-fixer with some extra formatting rules, as far as I know.

@Uzaaft
Copy link
Member

Uzaaft commented Dec 5, 2025

@wert2all Have you tested this pack yet? I see it imports the php pack, which uses the php-cs-fixer. Just want to make sure nothing collides.

Yes, I created a PR from my config.

20251205_12h52m44s_grim > > which uses the php-cs-fixer.

pint is wrapper over php-cs-fixer with some extra formatting rules, as far as I know.

Yeah I know that pint is a wrapper. What I am wondering is if you use the current pack as is, where its pulling in php-cs-fixer, could we end up in a scenario where both formatters try to apply different styles.

@wert2all
Copy link
Contributor Author

wert2all commented Dec 5, 2025

Yeah I know that pint is a wrapper. What I am wondering is if you use the current pack as is, where its pulling in php-cs-fixer, could we end up in a scenario where both formatters try to apply different styles.

I set up "stevearc/conform.nvim" to use one fornatter :

        php = { "pint" },
      }, 

How can I check how many formatters are executing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants