-
-
Notifications
You must be signed in to change notification settings - Fork 305
feat(laravel): add Pint formatter support #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
Uzaaft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From pint readme:
Pint is built on top of PHP-CS-Fixer and makes it simple to ensure that your code style stays clean and consistent.
Cant php-cs-fixer me removed?
a2b1cd9 to
4572a34
Compare
removed and force pushed |
|
@wert2all Have you tested this pack yet? I see it imports the php pack, which uses the php-cs-fixer. Just want to make sure nothing collides. |
Yes, I created a PR from my config.
pint is wrapper over php-cs-fixer with some extra formatting rules, as far as I know. |
Yeah I know that pint is a wrapper. What I am wondering is if you use the current pack as is, where its pulling in php-cs-fixer, could we end up in a scenario where both formatters try to apply different styles. |
I set up "stevearc/conform.nvim" to use one fornatter : How can I check how many formatters are executing? |


📑 Description
Laravel Pint is an opinionated PHP code style fixer for Laravel. This PR will install
pintLSP and add formatter for php files.